Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing statement_list #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dvmarcilio
Copy link

@dvmarcilio dvmarcilio commented Dec 19, 2022

Hi. We want to match the child nodes of a block in a single capture. Thus, I'm exposing statement_list.

Currently, if we match a block, we also get the braces { }.

By exposing statement_list, we can match the content without the braces. Below is a local playground with the modification.

Checklist:

  • All tests pass in CI.
  • There are sufficient tests for the new fix/feature.
  • Grammar rules have not been renamed unless absolutely necessary.
  • The conflicts section hasn't grown too much.
  • The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

@aryx
Copy link
Contributor

aryx commented Dec 19, 2022

@maxbrunsfeld do we have some rules for this kind of change? Seems fine to me, but this add intermediate
nodes in the CST.

@ketkarameya
Copy link

@maxbrunsfeld does this change look ok ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants