Queries #292
Open
Queries #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Gauteab, thanks for the contribution!
Yes, please revert the styling changes, since they're not a substantive part of the PR. It's much harder for us to review if the diff contains a bunch of cosmetic changes to unrelated parts of the file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think Queries are working properly.
This is the first time did anything with the FFI, so there are a few things I am unsure about.
I moved
Structinto a new module to use it in Query. This should maybe be moved into anInternaldirectory.I don't fully understand
Storable, so I left some things unfinished there. ParticularlyTSQueryErrorwhich is currently just an Int.While testing a bridged
ts_node_stringbefore seeing there was already an open issue. I also made a helper to call it on aNode.Finally, I ran clang format (automatically) with WebKit styling on bridge.c. If it was using a particular formatter I can revert that.