Set minimum go version to 1.22 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep - was not intentional, thanks for the PR! |
JohnMurray
added a commit
to JohnMurray/tree-sitter-java
that referenced
this pull request
Sep 30, 2024
amaanq
pushed a commit
to tree-sitter/tree-sitter-java
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the tin, I'd like to set the minimum version to 1.22 from 1.23 (the latest).
My reasoning is that folks don't always immediately move to the latest version and I'm hoping this repo could exist at a more friendly minimum Go version. Given the newness of the repo, I suspect this may not have been intentional, but it may be good to have some sort of documented policy on the supported Go version(s).