Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardization update #138

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Standardization update #138

merged 5 commits into from
Mar 13, 2024

Conversation

ObserverOfTime
Copy link
Member

This PR updates the repository to use the new bindings and standard workflows.

I've invited you to the crates team in the org in order to automate the publication.
After accepting the invitation, you should add the org as an owner:

cargo owner --add "github:tree-sitter-grammars:crates"

I've bumped the version to 0.2.0 and will tag it once the PR has been tested and merged.

So the org-wide ones can be used
@clason
Copy link
Collaborator

clason commented Mar 13, 2024

@MDeiml

@MDeiml
Copy link
Collaborator

MDeiml commented Mar 13, 2024

This PR updates the repository to use the new bindings and standard workflows.

I've invited you to the crates team in the org in order to automate the publication. After accepting the invitation, you should add the org as an owner:

cargo owner --add "github:tree-sitter-grammars:crates"

I've bumped the version to 0.2.0 and will tag it once the PR has been tested and merged.

I get the following error message

    Updating crates.io index
error: failed to invite owners to crate `tree-sitter-md` on registry at https://crates.io

Caused by:
  the remote server responded with an error (status 400 Bad Request): could not find the github team tree-sitter-grammars/crates

@ObserverOfTime
Copy link
Member Author

You probably need to authorize crates on your account. See here.

@MDeiml
Copy link
Collaborator

MDeiml commented Mar 13, 2024

I did, thanks!

Also thanks for this PR, it seems like it probably was a lot of work.

@ObserverOfTime
Copy link
Member Author

Not really, just the multi-language part.

Copy link
Collaborator

@MDeiml MDeiml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me besides this one minor nitpick which I'm happy to ignore. Of course I can't check everything in detail, especially all the new bindings (which are I guess just templates anyways?)

@@ -97,7 +97,7 @@ impl<'a> MarkdownCursor<'a> {
/// current node is an inline or block node.
///
/// See also [`field_name`](Self::field_name).
pub fn field_id(&self) -> Option<u16> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is not really forward compatible (which would mean a major version bump) but I don't think it should cause big trouble for anyone.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type was changed upstream in 0.21.0.

@ObserverOfTime
Copy link
Member Author

especially all the new bindings (which are I guess just templates anyways?)

Yeah, with some modifications to include both languages.

Neovim requires separate libraries
@ObserverOfTime ObserverOfTime merged commit 7bea7a9 into split_parser Mar 13, 2024
5 checks passed
@ObserverOfTime ObserverOfTime deleted the update branch March 13, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants