-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardization update #138
Conversation
So the org-wide ones can be used
e956de5
to
7813aba
Compare
I get the following error message
|
You probably need to authorize crates on your account. See here. |
I did, thanks! Also thanks for this PR, it seems like it probably was a lot of work. |
Not really, just the multi-language part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me besides this one minor nitpick which I'm happy to ignore. Of course I can't check everything in detail, especially all the new bindings (which are I guess just templates anyways?)
@@ -97,7 +97,7 @@ impl<'a> MarkdownCursor<'a> { | |||
/// current node is an inline or block node. | |||
/// | |||
/// See also [`field_name`](Self::field_name). | |||
pub fn field_id(&self) -> Option<u16> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is not really forward compatible (which would mean a major version bump) but I don't think it should cause big trouble for anyone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type was changed upstream in 0.21.0
.
Yeah, with some modifications to include both languages. |
Neovim requires separate libraries
This PR updates the repository to use the new bindings and standard workflows.
I've invited you to the crates team in the org in order to automate the publication.
After accepting the invitation, you should add the org as an owner:
cargo owner --add "github:tree-sitter-grammars:crates"
I've bumped the version to 0.2.0 and will tag it once the PR has been tested and merged.