replace window.* by self.* in order to support service worker context #271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package works perfectly well, but when you use it in a service worker context, it failed because
window.*
access is not support by service worker.So in order to support this package into service worker, we should make a little change, replace any
window.*
usage byself.*
.So self will work for non-window contexts where this code can be executed, so with this change this package can be used into a service worker without any problem 😄 .