Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up Docker compose file #39

Merged

Conversation

jlaacke
Copy link
Contributor

@jlaacke jlaacke commented Aug 11, 2021

  • Removed voorwiel from docker compose file since it is always built separately
  • Always restart cykel related docker containers to use them like daemon processes
  • Removed ALLOWED_HOSTS, since they are configured via .env file

@robbi5
Copy link
Contributor

robbi5 commented Aug 11, 2021

Thanks for the PR :)
Just one question: do you have a special reason to add the api/stations/location endpoint for gps coordinates of stations, or could you use the ones already provided by the station_information.json from GBFS (https://github.com/stadtulm/cykel/blob/master/gbfs/serializers.py#L62)?

@jlaacke jlaacke changed the title Get locations from stations for station based rent Cleaned up Docker compose file Aug 12, 2021
@jlaacke
Copy link
Contributor Author

jlaacke commented Aug 12, 2021

@robbi5 You are absolutely right, we don't need an additonal API for that. So I removed that and changed the title of the PR. ;) The voorwiel PR is ready to go: transportkollektiv/voorwiel#28

@robbi5 robbi5 merged commit 95c4aa2 into transportkollektiv:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants