Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve writeCheckpoint in MySQL storage implementation #82

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

roger2hk
Copy link
Contributor

#21

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 32.92%. Comparing base (46ec9c2) to head (8436b6f).
Report is 5 commits behind head on main.

Files Patch % Lines
storage/mysql/mysql.go 0.00% 16 Missing ⚠️
cmd/example-mysql/main.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   35.80%   32.92%   -2.89%     
==========================================
  Files          16       18       +2     
  Lines        1363     1458      +95     
==========================================
- Hits          488      480       -8     
- Misses        801      906     +105     
+ Partials       74       72       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

go.mod Show resolved Hide resolved
storage/mysql/mysql.go Outdated Show resolved Hide resolved
@roger2hk roger2hk merged commit 999c97d into transparency-dev:main Jul 24, 2024
4 checks passed
@roger2hk roger2hk deleted the mysql-write-checkpoint branch July 24, 2024 09:24
phbnf pushed a commit to phbnf/trillian-tessera that referenced this pull request Jul 24, 2024
…cy-dev#82)

* Improve `writeCheckpoint` in MySQL storage implementation

* Remove unused `WriteCheckpointFunc`

* Use `rfc6962.DefaultHasher.EmptyRoot()` as the initial checkpoint root hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants