Add support for h2c to GCP conformance and HTTP/2 to hammer #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCutter
force-pushed
the
gcp_h2c
branch
9 times, most recently
from
03b369b
to
b099941
Compare
AlCutter
changed the title
AlCutter
changed the title
AlCutter
force-pushed
the
gcp_h2c
branch
9 times, most recently
from
228acdf
to
004f335
Compare
AlCutter
force-pushed
the
gcp_h2c
branch
3 times, most recently
from
6c25289
to
b7b4ca8
Compare
roger2hk
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the use of HTTP2/Cleartext (h2c) in the GCP conformance server, and adds an flag to optionally force HTTP/2 usage in the hammer.
HTTP/2 supports much better multiplexing of requests over a socket connection compared to HTTP/1.1, which in turn results in better performance and fewer errors when sending a large number of concurrent requests (e.g. when running the hammer against a conformance server).
CloudRun detects and supports h2c if implemented by the server its hosting, otherwise it will downgrade incoming HTTP/2 requests to HTTP/1.