Remove multiconfig #207
Merged
Remove multiconfig #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm broken test, let me see |
AlCutter
approved these changes
Sep 5, 2024
personalities/sctfe/config.go
Outdated
| } | ||
| } | ||
|
|
||
| if len(cfg.Config) == 0 { | ||
| if cfg.Origin == "" { |
There was a problem hiding this comment.
nit: probably should update the error string on the next line to match the check, or better still just remove this test (it's already performed in the ValidateLogConfig method below).
There was a problem hiding this comment.
Hehe, it's coming: dced84e. I've bumped this edit to this PR, it was not too hard of a rebase to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #200 and #88
First step towards deleting the config proto.