POSIX oneshot: refactor code out of main method #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhutchinson
force-pushed
the
posix-oneshot-refactor1
branch
from
51d6f8b
to
d32f661
Compare
The goal here is that the main method should contain only the interesting code for putting the entries in the log. This PR moves code into methods to aid readability: - initializing the verifier - initializing the signer - evaluating the glob This fixes a bug where it would deadlock due to filling entryChan if more than 100 leaves were added at a time.
mhutchinson
force-pushed
the
posix-oneshot-refactor1
branch
from
d32f661
to
2b51424
Compare
AlCutter
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is that the main method should contain only the interesting code for putting the entries in the log. This PR moves code into methods to aid readability: