Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deduplication related code and doc in MySQL storage #183

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Remove deduplication related code and doc in MySQL storage #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions docs/design/mysql_storage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@ An internal tile consisting of hashes. There is one row for each internal tile,
#### `TiledLeaves`

The data committed to by the leaves of the tree. Follows the same evolution as Subtree.

#### `HashIndex`

An optional table that allows deduplication to be implemented efficiently.

Reads can scale horizontally with very little overhead or contention between frontends.

Expand Down
2 changes: 0 additions & 2 deletions storage/mysql/mysql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,6 @@ func (s *Storage) writeEntryBundle(ctx context.Context, tx *sql.Tx, index uint64

// Add is the entrypoint for adding entries to a sequencing log.
func (s *Storage) Add(ctx context.Context, entry *tessera.Entry) (uint64, error) {
// TODO(#21): Return index if the value is already stored.

return s.queue.Add(ctx, entry)()
}

Expand Down
Loading