Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect http status not found behaviour in MySQL storage #131

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

roger2hk
Copy link
Contributor

#21

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 34.88%. Comparing base (46ec9c2) to head (71830c3).
Report is 48 commits behind head on main.

Files Patch % Lines
cmd/example-mysql/main.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   35.80%   34.88%   -0.93%     
==========================================
  Files          16       33      +17     
  Lines        1363     2775    +1412     
==========================================
+ Hits          488      968     +480     
- Misses        801     1699     +898     
- Partials       74      108      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

storage/mysql/mysql.go Show resolved Hide resolved
@roger2hk roger2hk merged commit fd57780 into transparency-dev:main Aug 13, 2024
7 checks passed
@roger2hk roger2hk deleted the fix-mysql-404 branch August 13, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants