Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MySQL tlog tiles API integration test #128

Merged

Conversation

roger2hk
Copy link
Contributor

@roger2hk roger2hk commented Aug 8, 2024

#8 #21

This PR not only add the MySQL tlog tiles API integration test but also fixes the read entry bundle API bug in example-mysql.

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 34.92%. Comparing base (46ec9c2) to head (24f1e9e).
Report is 48 commits behind head on main.

Files Patch % Lines
cmd/example-mysql/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   35.80%   34.92%   -0.89%     
==========================================
  Files          16       33      +17     
  Lines        1363     2772    +1409     
==========================================
+ Hits          488      968     +480     
- Misses        801     1696     +895     
- Partials       74      108      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roger2hk roger2hk force-pushed the mysql-tlog-tiles-integration-test branch 5 times, most recently from 8a4b718 to ca38ef7 Compare August 10, 2024 21:52
@roger2hk roger2hk marked this pull request as ready for review August 10, 2024 22:01
@roger2hk roger2hk force-pushed the mysql-tlog-tiles-integration-test branch from ca38ef7 to 8e6200d Compare August 10, 2024 22:08
@roger2hk
Copy link
Contributor Author

roger2hk commented Aug 10, 2024

Some refactoring TODOs in my mind:

  • Apply the same integration test to GCP
    • Move integration_test.go from integration/example-mysql/ to integration/
    • Add new job gcp-tlog-tiles-api to .github/workflows/integration_test.yml
  • Add CheckInclusionProof in tlog tiles client.
  • Add write API in tlog tiles client. (Possibily move the one from hammer?)

@roger2hk roger2hk force-pushed the mysql-tlog-tiles-integration-test branch 2 times, most recently from 0d88f13 to 75ee312 Compare August 10, 2024 22:26
@roger2hk roger2hk force-pushed the mysql-tlog-tiles-integration-test branch from 75ee312 to 24f1e9e Compare August 10, 2024 22:40
@roger2hk roger2hk merged commit 51b692a into transparency-dev:main Aug 13, 2024
7 checks passed
@roger2hk roger2hk deleted the mysql-tlog-tiles-integration-test branch August 13, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants