Fixed interval for online checks #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
=======================================
Coverage ? 30.57%
=======================================
Files ? 8
Lines ? 664
Branches ? 0
=======================================
Hits ? 203
Misses ? 432
Partials ? 29 ☔ View full report in Codecov by Sentry. |
mhutchinson
approved these changes
Oct 23, 2024
|
(@mhutchinson needs a re-approval now :/ ) |
mhutchinson
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the "are the devices online" graphs look for life signs over a fixed interval of 5m, rather than an interval defined by whatever range the UI is currently graphing.
This is needed because the interval between distribution attempts is fixed, and relatively infrequent, so we start to see "bumps" of unavailability once you zoom in to ranges of ~1h or less.