Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the local Docker image name. Also fix some merge overwrites. #80

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Simplify the local Docker image name. Also fix some merge overwrites. #80

merged 1 commit into from
Aug 8, 2023

Conversation

jiggoha
Copy link
Contributor

@jiggoha jiggoha commented Aug 3, 2023

No description provided.

mhutchinson
mhutchinson approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@mhutchinson mhutchinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is much better. The full namespacing suggested a remote repository. This is clearer that we're not intending this to get further than the local machine's docker registry.

@jiggoha jiggoha merged commit 6166da9 into main Aug 8, 2023
3 checks passed
@jiggoha jiggoha deleted the rename branch August 8, 2023 12:09
@jiggoha jiggoha mentioned this pull request Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhutchinson mhutchinson mhutchinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiggoha @mhutchinson