Sstandardized Logging and Fixed a Bug #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kushagrabhushan is this bug still valid, we have figured out logging! |
|
The bug was with the reactnet model class. I fixed that in this PR. |
|
the code is majorly refactored, can you pin-point the exact bug and we can open a new PR |
|
It was incorrectly creating the student model. It was using normal resnet instead of binarisable ones. |
|
can you create a new PR with the current dev branch focused only on this bug or maybe raise an issue if it is too much work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*All methods now create a logging file which stores the train acc, train loss, val acc and val loss along with a few other things.