Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export fix for large datasets #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ranchobiosciencesdev
Copy link

@ranchobiosciencesdev ranchobiosciencesdev commented May 26, 2016

Exceeding of the DB parameters count within one transaction is fixed.

@ranchobiosciencesdev ranchobiosciencesdev changed the title Export fix for large datasers Export fix for large datasets May 26, 2016
@Terry-Weymouth
Copy link

Please annotate the ID of the committer with contact information.

@ricepeterm
Copy link

Failed test testNumericDataIsInNumericForm (presumably due to changed datatype).
Can the test be fixed in the pull request?
Does this fix address https://jira.transmartfoundation.org/browse/TRANSREL-66

@forus
Copy link

forus commented Oct 18, 2016

@ranchobiosciencesdev We fixed the same issue for patients and assays. We choose to use subqueries instead. something like this ... where patient_num in (1, 2, 3, ...) ... => ... where patient_num in (select patient_num from qt_patient_set_collection where result_instance_id = 100) .... Could we maybe use the same approach for concepts. For more then 10000 concepts there must be single parent on the tree...

@forus
Copy link

forus commented Oct 18, 2016

Alternatively you might want to return ChoppedInQueryCondition back to life.
http://clover.thehyve.net/transmart-core-db/transmart-132.1-master/org/transmartproject/db/support/ChoppedInQueryCondition.html
It was deleted because we decided to use subqueries to fix the issue.

@forus forus mentioned this pull request Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants