Move tests from TraP #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
suvayu
commented
Oct 23, 2024
suvayu
commented
- Add missing tests from TraP
- Mark mysteriously failing tests as xfail
- Fix round trip pickling
NOTE: include necessary binary data files Fixes: #65
Don't know why these tests test for failure. IIUC, they should pass.
The following tests from test_pickle.py were failing: - aartfaac_casatable - fits - fitsblob - lofar_casatable This is because the `__getattr__` implementation was incorrect. Python expects it to raise AttributeError when no attribute is found; see: https://docs.python.org/3/reference/datamodel.html#object.__getattr__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.