Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docstrings and arg descriptions in example notebook, to better… #56

Merged
merged 1 commit into from
May 14, 2024

Conversation

EgorKraevTransferwise
Copy link
Collaborator

Context

Update docstrings and arg descriptions in example notebook, to better describe solver arg

Checklist

@wise-github-bot-app
Copy link

🔴

Your CODEOWNERS file is broken, fix the following errors before merging the branch:

  • The CODEOWNERS file does not exist. Repository ownership will default to ENGINEERING until you add a CODEOWNERS file with a * rule that assigns it to a team

@AlxdrPolyakov AlxdrPolyakov merged commit 6a9f610 into main May 14, 2024
7 of 9 checks passed
@wise-github-bot-app
Copy link

The approval(s) from AlxdrPolyakov do(es)n't fullfill the approvers requirements because:

  • The approver's cost centre, PRDANA, maps to the ANALYST business function. As the code that was changed is owned by ENGINEERING, this approval won't satisfy our separation of duties check. We'll need an additional approval from someone in ENGINEERING. This approval may still help satisfy other codeowner requirements.

@AlxdrPolyakov AlxdrPolyakov deleted the solver_docstrings branch September 5, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants