Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly call statsmodels.fit_regularized() for regularization #8

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Properly call statsmodels.fit_regularized() for regularization #8

merged 2 commits into from
Sep 27, 2024

Conversation

EgorKraevTransferwise
Copy link
Contributor

@EgorKraevTransferwise EgorKraevTransferwise commented Sep 26, 2024 •
edited
Loading

Context

Properly call statsmodels.fit_regularized() for regularization - replaces the two-stage ugly hack that was there

Checklist

@EgorKraevTransferwise EgorKraevTransferwise requested a review from a team as a code owner September 26, 2024 16:24
@EgorKraevTransferwise EgorKraevTransferwise mentioned this pull request Sep 26, 2024
Closed
bkoseoglu
bkoseoglu approved these changes Sep 27, 2024
View reviewed changes
shap_select/select.py Show resolved Hide resolved
@EgorKraevTransferwise EgorKraevTransferwise merged commit c0673fa into main Sep 27, 2024
8 checks passed
@EgorKraevTransferwise EgorKraevTransferwise deleted the regularization_sm branch September 27, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkoseoglu bkoseoglu bkoseoglu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EgorKraevTransferwise @bkoseoglu