This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently the schema for json columns is
object
, but the actual value emitted is a string.Proposed changes
The schema and the records need to match eachother. This change resolved this bug by making the record match the schema.
This is covered in issue 99. The open PR (101) to make the schema match the record. This isn't as favourable because it means json parsing must be done again on the target side.
I'm not very familiar with spatial datatypes in MySQL, so I can't say how this will affect them. I'm happy to write some tests if someone could point to an example of what they should look like.
Types of changes
When a column has
object
as one of it's type, it will be parsed from a json string to a python dict.This may result in a
JSONDecodeError
if the json is malformatted.Checklist
setup.py
is an individual PR and not mixed with feature or bugfix PRs[AP-NNNN]
(if applicable. AP-NNNN = JIRA ID)AP-NNN
(if applicable. AP-NNN = JIRA ID)