Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UI language matching #186

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Improve UI language matching #186

merged 4 commits into from
Oct 21, 2024
+23 −21

Conversation

eligrey
Copy link
Member

@eligrey eligrey commented Oct 18, 2024

Related Issues

Security Implications

[none]

System Availability

[none]

@height Height
Copy link

height bot commented Oct 18, 2024

This pull request has been linked to 1 task:

  • T-39633 Higher priority localizations not displayed by default in consent banners, if english exists at a lower priority language in browser settings (unlink task)

💡Tip: Add "Close T-39633" to the pull request title or description, to a commit message, or in a comment to mark this task as "Pending Deploy" when the pull request is merged.

@vercel Vercel
Copy link

vercel bot commented Oct 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
consent-manager-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 6:20pm

@eligrey eligrey requested a review from a team October 21, 2024 18:17
@eligrey eligrey changed the title Improved UI language matching Fix UI language matching Oct 21, 2024
csmccarthy
csmccarthy approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@csmccarthy csmccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tysm!

kate-kazantseva
kate-kazantseva reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@kate-kazantseva kate-kazantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@eligrey eligrey merged commit 27dc599 into main Oct 21, 2024
11 checks passed
@eligrey eligrey changed the title Fix UI language matching Improve UI language matching Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csmccarthy csmccarthy csmccarthy approved these changes

@kate-kazantseva kate-kazantseva kate-kazantseva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eligrey @csmccarthy @kate-kazantseva