Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pins react intl version #178

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

michaelfarrell76
Copy link
Member

customer hit an issue updating ui version related to react-intl

Screenshot 2024-10-01 at 1 26 29 PM

@michaelfarrell76 michaelfarrell76 requested a review from a team October 1, 2024 20:26
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
consent-manager-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 8:26pm

Copy link
Member

@eligrey eligrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, that's annoying. libraries should not be trying to de-dupe themselves without 'well-known attestation contracts' explicitly designed for this purpose -- it's why import() and export were added natively to JS 😬 (for the JS engine to handle this itself). it's unfortunate that react-intl works like that..

@michaelfarrell76 michaelfarrell76 merged commit affa6b5 into main Oct 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants