Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to enable/disable specific languages #136

Merged
merged 7 commits into from
Aug 10, 2023

Conversation

michaelfarrell76
Copy link
Member

@michaelfarrell76 michaelfarrell76 commented Aug 10, 2023

Related Issues

  • links https://transcend.height.app/T-22

  • New: airgap.js data attribute data-languages allows for specifying the specific set of languages that should be shown in the LanguageOptions view state. data-languages="en,es-ES,fr-FR" can be used to enable english, spanish and french options only. data-languages="en" can be used to enable english only. When only one option is enabled, the translation button is disabled entirely.

Screenshot 2023-08-10 at 3 36 27 PM Screenshot 2023-08-10 at 3 37 32 PM

@vercel
Copy link

vercel bot commented Aug 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
consent-manager-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 10:53pm

@height
Copy link

height bot commented Aug 10, 2023

This pull request has been linked to 1 task:

  • T-22451 Consent UI - Allow customers to select the set of languages they want to enable from the admin dashboard (unlink task)

💡Tip: Add "Close T-22451" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@michaelfarrell76 michaelfarrell76 requested review from a team August 10, 2023 22:39
eligrey
eligrey previously approved these changes Aug 10, 2023
Copy link
Member

@eligrey eligrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a small nit: I think this should be data-supported-languages or data-languages

@michaelfarrell76
Copy link
Member Author

@eligrey ill update to data-languages!

src/config.ts Outdated Show resolved Hide resolved
eligrey
eligrey previously approved these changes Aug 10, 2023
Co-authored-by: Eli Grey <[email protected]>
@michaelfarrell76 michaelfarrell76 merged commit 4bc9f71 into main Aug 10, 2023
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the michaelfarrell76/support-langes branch August 10, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants