Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposes transcend.setPrivacyPolicy API #130

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

michaelfarrell76
Copy link
Member

Related Issues

Screen.Recording.2023-07-13.at.3.05.04.PM.mov

@michaelfarrell76 michaelfarrell76 requested review from banzzai and a team July 13, 2023 22:06
@height
Copy link

height bot commented Jul 13, 2023

This pull request has been linked to 1 task:

💡Tip: Add "Close T-26915" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@vercel
Copy link

vercel bot commented Jul 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
consent-manager-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2023 10:09pm

{} as TConfigContext,
);

export const ConfigProvider = ({
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i removed this due to reducing complexity - there are so few layers to this project that adding a global state variable is not really necessary. it made this code more complex and makes the other react components slightly harder to unit test (once we add unit tests)

@michaelfarrell76 michaelfarrell76 merged commit c6e34c7 into main Jul 13, 2023
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the michaelfarrell76/new-set-policy-api branch July 13, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants