WIP - Reading a file #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmywarting
commented
Jul 10, 2019
read.js
Outdated
| array: dataArray, | ||
| view: new DataView(dataBuffer) | ||
| } | ||
| } |
There was a problem hiding this comment.
Thinking maybe (hopefully) that we might not need this bloated helper fn
|
reading our own generated zip file, easy |
(meaning it was deflated) we only copy over files - we don't have any deflation
Mistakenly put the compression method to 8
eligrey
approved these changes
Jul 11, 2019
# Conflicts: # example/index.html # read.js
|
will make a new PR later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sweet, I manage to read the "End of central directory record" and parse it.
Now i know some info about each entry.
Next step is to actually read it.
since our generated zip is uncompressed i did a simple
zip.slice(start, end)on the generated blob to read the content of the file for now.i know it's not airbnb style, but i will change it later.
Still lots of more stuff to be done here.
I mostly did it so i can get a better understanding of the underlying protocol so i can learn more how zip works, want to eventually get zip64 format support (#8)
#9