Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to v3 #39

Merged
merged 12 commits into from
Jan 9, 2018
Merged

migrate to v3 #39

merged 12 commits into from
Jan 9, 2018

Conversation

jaumard
Copy link
Contributor

@jaumard jaumard commented Nov 25, 2017

No description provided.

@jaumard
Copy link
Contributor Author

jaumard commented Nov 25, 2017

TravisCI crash on node 7 because or trails dependencies, waiting for the team feedback on this (trailsjs/trails#313 related)

Copy link
Member

@scott-wyatt scott-wyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good enough for now, obviously, we will need to support resolvers once there is more clarity on how those are done, but this is good for a v3 release!

@jaumard
Copy link
Contributor Author

jaumard commented Nov 26, 2017

Yeah maybe when more docs and more example show how resolvers works we can try to be compliant with them :)

@scott-wyatt
Copy link
Member

I'm guessing we need to release this as 3.0.1 or 3.1.0?

@jaumard
Copy link
Contributor Author

jaumard commented Nov 26, 2017

I put 3.1.0 on the package.json file as there some important changes

@scott-wyatt
Copy link
Member

Cool, merge if you please :-)

@jaumard jaumard merged commit 7cb25da into master Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants