-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[36467] Add API users form and schema endpoints #9090
Conversation
fd99aa3
to
969eecb
Compare
969eecb
to
a18dc13
Compare
a18dc13
to
01d4cf7
Compare
bcb534a
to
1edabd7
Compare
1edabd7
to
6e56bd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from what I noted down in code, these are the things I noted when using the API
- The
name
property is not described in the schema -
firstName
andlastName
are described as non writable - The
password
property is described although it does not exist on the user resource - Attributes turn up in the form's payload although they are not writable (e.g.
name
):
The name property is not accessible directly for users
The password property is a write-only property so it's not contained in the payload. It can still be set and written as per the schema |
@ulferts I believe addressed all remarks |
1d3c395
to
b1b9591
Compare
8ecca64
to
c3edd40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks for fixing the user API description along the way.
Attribute conversion fixes
firstName and lastName of user were not correctly converted to the frontend. That resulted in
validationErrors
properties containing the backend keysfirstname
andlastname
. This has been fixed.Representable nil patch
A patch is added for representable to fix trailblazer/representable#234, since
Setter
is not being applied when the input is nil.https://community.openproject.com/work_packages/36467