Fix expectation with changed attribute mapping

opf · Mar 15, 2021 · a18dc13 · a18dc13
1 parent 803fedd
commit a18dc13
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/lib/api/v3/users/user_representer.rb b/lib/api/v3/users/user_representer.rb
@@ -149,10 +149,7 @@ class UserRepresenter < ::API::V3::Principals::PrincipalRepresenter
                  setter: ->(fragment:, represented:, **) { represented.status = User.statuses[fragment.to_sym] },
                  exec_context: :decorator,
                  render_nil: true,
-                 cache_if: -> {
-                   binding.pry
-                   current_user_can_manage?
-                 }
+                 cache_if: -> { current_user_can_manage? }
 
         property :identity_url,
                  exec_context: :decorator,

diff --git a/spec/requests/api/v3/user/create_user_common_examples.rb b/spec/requests/api/v3/user/create_user_common_examples.rb
@@ -70,7 +70,7 @@
 
       expect(errors.count).to eq(5)
       expect(errors.collect { |el| el['_embedded']['details']['attribute'] })
-        .to contain_exactly('password', 'login', 'firstname', 'lastname', 'email')
+        .to contain_exactly('password', 'login', 'firstName', 'lastName', 'email')
 
       expect(last_response.body)
         .to be_json_eql('urn:openproject-org:api:v3:errors:MultipleErrors'.to_json)
@@ -131,7 +131,7 @@
         expect(errors.count).to eq 4
 
         attributes = errors.map { |error| error.dig('_embedded', 'details', 'attribute') }
-        expect(attributes).to contain_exactly('login', 'firstname', 'lastname', 'email')
+        expect(attributes).to contain_exactly('login', 'firstName', 'lastName', 'email')
       end
     end
   end