Cells are ready for Ruby 3.4.0 #509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to make #inpect to not blow up screen wher controller with request and helpers included in instance of the ViewModel
…endency bump cells-erb dev dependency to >= 0.1.0
README: Build badge point to trailblazer/cells
Ruby 2.2 is reaching it's end of life at the end of the month. But I think it's useful to test recent Ruby versions as well.
Update tested Ruby version
Add concise #inspect to ViewModel
Fix warning for undefined instance variable
Tilt::Cache is a generic key-value store. This works exactly the same, if we move some code around.
The find loop is necessary to find out which prefix contains the template that we are looking for. Template parsing happens for the first template that is found. If we split the file lookup and template building, the code becomes easier to read and easier to maintain.
Drop support for old rubies
CI: Drop unused Travis sudo: false directive
update minitest syntax
Update documentation links
In `Caching`, we compile `cache_fillter_args` from `args` and `kws`. As per the existing implementation, cache filters do not expect/can't receive keyword arguments anyway.
CI: add Ruby 3.2 to the test matrix
As per https://guides.rubygems.org/specification-reference/#metadata, add metadata to the gemspec file. This'll allow people to more easily access the source code, raise issues and read the changelog. These bug_tracker_uri, changelog_uri, documentation_uri, homepage_uri, source_code_uri, and wiki_uri links will appear on the rubygems page at https://rubygems.org/gems/cells and be available via the Rubygems API after the next release.
Add project metadata to the gemspec
There are several files in the gem package that aren't useful for downstream projects. Removing these files reduces the gem package size from 34K to 24K!
Release v4.2.0
Ruby 3.4 has added to Kernel#caller the class and the method, e.g. Object#foo, before the method was only displayed.
apotonick
reviewed
Nov 12, 2024
test/public_test.rb
Outdated
| _(options.to_s).must_equal "{:genre=>\"Fusion\", :collection=>[Object]}" | ||
|
|
||
| if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('3.4.0') | ||
| _(options.to_s).must_equal "{:genre=>\"Fusion\", :collection=>[Object]}" |
There was a problem hiding this comment.
Please use https://github.com/trailblazer/trailblazer-core-utils/blob/master/lib/trailblazer/core/utils/inspect.rb#L4 for Hash#inspect 🍻
|
Wow, thanks so much for your work! 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.