-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes/render results #37
Changes from all commits
56327e4
fbad682
0853c82
f2291e3
5c7d4e3
fb6c69a
9e65b80
ead428f
76fe1ef
7bdcfd1
fb0a510
5258655
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,6 @@ h5py==2.6.0 | |
jupyter==1.0.0 | ||
numpy==1.11.0 | ||
Pillow==3.2.0 | ||
pyosmium==2.6.0 | ||
pyproj==1.9.5.1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. out of curiosity, do we not need this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It gets installed from source in the Dockerfile, I think pyosmium might not be pippable at all? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's cool if we don't include pyosmium in the file, but we should probably add a comment explaining the dependencies that aren't included in requirements, so that it's documented at least (since people will expect to look in requirements for the python dependencies). Btw, I managed to install pyosmium with pip. See the last line of the first code block in my comment on issue 8 here for the magic incantation. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, I'll see if I can try and get that to pip install like you have then, via reqs. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You won't be able to add the includes flag via requirements.txt (and even if you did, it probably wouldn't be good, since it takes a hardcoded path), which is why I'm fine if we don't include pyosmium. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK, I thought I could add those flags in Dockerfile, but I see why that won't really work or help. I'll add a note to reqs about pyosmium. |
||
requests==2.10.0 | ||
s3cmd==1.6.1 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh yes... I knew I was forgetting something... thanks