fix(Traefik): Apply suggestions from code review

Co-authored-by: Michel Loiseleur <[email protected]>
traefik · Nov 18, 2024 · e678259 · e678259
1 parent 88705ca
commit e678259
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/traefik/templates/_podtemplate.tpl b/traefik/templates/_podtemplate.tpl
@@ -462,11 +462,11 @@
            {{- if .Values.providers.kubernetesCRD.allowExternalNameServices }}
           - "--providers.kubernetescrd.allowExternalNameServices=true"
            {{- end }}
-           {{- if .Values.providers.kubernetesCRD.allowEmptyServices }}
-          - "--providers.kubernetescrd.allowEmptyServices=true"
-           {{- else }}
-          - "--providers.kubernetescrd.allowEmptyServices=false"
+          {{- if ne .Values.providers.kubernetesCRD.allowEmptyServices nil }}
+           {{- with .Values.providers.kubernetesCRD.allowEmptyServices | toString }}
+          - "--providers.kubernetescrd.allowEmptyServices={{ . }}"
            {{- end }}
+          {{- end }}
            {{- if and .Values.rbac.namespaced (semverCompare ">=3.1.2-0" $version) }}
           - "--providers.kubernetescrd.disableClusterScopeResources=true"
            {{- end }}
@@ -479,11 +479,11 @@
            {{- if .Values.providers.kubernetesIngress.allowExternalNameServices }}
           - "--providers.kubernetesingress.allowExternalNameServices=true"
            {{- end }}
-           {{- if .Values.providers.kubernetesIngress.allowEmptyServices }}
-          - "--providers.kubernetesingress.allowEmptyServices=true"
-           {{- else }}
-          - "--providers.kubernetesingress.allowEmptyServices=false"
+          {{- if ne .Values.providers.kubernetesIngress.allowEmptyServices nil }}
+           {{- with .Values.providers.kubernetesIngress.allowEmptyServices | toString }}
+          - "--providers.kubernetesingress.allowEmptyServices={{ . }}"
            {{- end }}
+          {{- end }}
            {{- if and .Values.service.enabled .Values.providers.kubernetesIngress.publishedService.enabled }}
           - "--providers.kubernetesingress.ingressendpoint.publishedservice={{ template "providers.kubernetesIngress.publishedServicePath" . }}"
            {{- end }}