Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Update API to reflect changes to CLI interaction #884

Merged

Conversation

GuySartorelli
Copy link
Contributor

@GuySartorelli GuySartorelli marked this pull request as draft September 6, 2024 03:10
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this because the translatable module hasn't been a thing for a really long time - it's time to remove this task.

@tractorcow
Copy link
Collaborator

Approved, but pending build to pass.

PHP Fatal error:  Type of TractorCow\Fluent\Task\InitialDataObjectLocalisationTask::$title must not be defined (as in class SilverStripe\Dev\BuildTask) in /home/runner/work/silverstripe-fluent/silverstripe-fluent/src/Task/InitialDataObjectLocalisationTask.php on line 20

@GuySartorelli
Copy link
Contributor Author

This PR (and it'll be the case with most of the CMS 6 PRs) relies on code in other PRs. They'll all need to be merged together.

@GuySartorelli GuySartorelli force-pushed the pulls/8/symfony-sake branch 2 times, most recently from 84ddaff to 0d4de77 Compare September 24, 2024 00:10
Copy link
Contributor

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test failures

@GuySartorelli
Copy link
Contributor Author

CI failures don't look related to the changes in this PR - running a regular CI run to see if it fails the same way. https://github.com/tractorcow-farm/silverstripe-fluent/actions/runs/11060232590

@GuySartorelli
Copy link
Contributor Author

Main CI isn't even getting that far.
I recommend we merge and then clean up CI in a broken builds card.

@emteknetnz emteknetnz merged commit c10b2d0 into tractorcow-farm:8 Sep 26, 2024
6 of 8 checks passed
@emteknetnz emteknetnz deleted the pulls/8/symfony-sake branch September 26, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants