Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove header filter from localisation grid field #876

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

satrun77
Copy link
Contributor

@satrun77 satrun77 commented Aug 19, 2024

Description

Manual testing steps

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@satrun77 satrun77 force-pushed the pull/localisation-search branch 2 times, most recently from f81f4b9 to ee46c91 Compare August 19, 2024 22:04
@satrun77 satrun77 marked this pull request as ready for review August 19, 2024 22:06
@satrun77 satrun77 changed the base branch from 7 to 7.1 August 19, 2024 22:06
@tractorcow
Copy link
Collaborator

Incorrect target branch?

@satrun77 satrun77 force-pushed the pull/localisation-search branch from ee46c91 to 93eea7f Compare August 19, 2024 22:12
@satrun77 satrun77 force-pushed the pull/localisation-search branch from 93eea7f to 4448bef Compare August 19, 2024 22:14
@satrun77
Copy link
Contributor Author

Incorrect target branch?

I targeted 7.1. Which branch do you want it to be?

@tractorcow
Copy link
Collaborator

No that's ok, I just saw lots of unrelated commit messages. It seems fine now.

@satrun77
Copy link
Contributor Author

No that's ok, I just saw lots of unrelated commit messages. It seems fine now.

Ah yes. I saw that and rebased before I saw your comment :) Thanks for looking into this PR

@tractorcow tractorcow merged commit dc85ba9 into tractorcow-farm:7.1 Aug 20, 2024
9 checks passed
@tractorcow
Copy link
Collaborator

fixed and thanks for the contribution.

@GuySartorelli
Copy link
Contributor

GuySartorelli commented Aug 26, 2024

Didn't see this PR in time - but it should probably be conditional on whether BasicSearchContext is available (i.e. whether framework 5.2+ is used) - see https://docs.silverstripe.org/en/5/developer_guides/forms/using_gridfield_with_arbitrary_data/#arraydata-filter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants