Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Issues when running with other modules installed #860

Merged

Conversation

emteknetnz
Copy link
Contributor

@emteknetnz emteknetnz commented Jun 6, 2024

Issue silverstripe/.github#271

There are two separate commits in here fixing different issues, do not squash merge

FIX Only select columns from the current database fixes the Duplicate columns in query issue

FIX Create a temp locale if there is not a default fixes the TractorCow\Fluent\Model\RecordLocale::__construct() issue

Copy link
Contributor

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add details about why each commit is actually needed. What errors are popping up, and which commit fixes which error(s)?

It's hard to test this without knowing what's being fixed by which code change.

src/Extension/FluentExtension.php Outdated Show resolved Hide resolved
src/Extension/FluentExtension.php Outdated Show resolved Hide resolved
src/Extension/FluentExtension.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz changed the title FIX Issues issues when running with other modules installed FIX Issues when running with other modules installed Jun 6, 2024
@emteknetnz
Copy link
Contributor Author

@GuySartorelli have added description to explain which issues commits are for

Copy link
Contributor

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 87abf4c into tractorcow-farm:7 Jun 6, 2024
10 checks passed
@GuySartorelli GuySartorelli deleted the pulls/7/fix-sink branch June 6, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants