Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Add ability to ignore domains entirely #829

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

lekoala
Copy link
Contributor

@lekoala lekoala commented Mar 20, 2024

Description

If you don't use domains, you shouldn't have to make a query on the table

Manual testing steps

Using debugbar, you can check the queries
With this new feature, this prevents this query: SHOW FULL FIELDS IN "Fluent_Domain"

Issues

#828

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@tractorcow
Copy link
Collaborator

LGTM

@tractorcow tractorcow merged commit 02d6dfa into tractorcow-farm:7 Mar 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants