-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Include custom ODFs #33
base: main
Are you sure you want to change the base?
Conversation
I wonder if odf_model should be renamed fodf_model and made its own task in tractography.py in the tasks folder. then it could be from an image file or a string, and that method in the tractography task folder either calls the appropriate data task method if its a string or calls the imagefile function if its an imagefile, similar to 'brain_mask'. this could also just be handled with if statements in the tractography method. I will work on this tomorrow |
I think if we go down this route to allow for custom fODF images that it would unlink these two procedures. I am in support of making them two separate tasks. |
After a conversation with @36000, I think that maybe we remove the "legacy" and "basis_type" options here, and leave that up to the user. Then, this code would still allow users to provide custom ODFs, but they would have to make sure that the coefficients are for the "descoteaux" basis set, and they'd have to do their own conversion in advance for this. @kellychang4 : WDYT? |
That is fine with me, so long as it is written somewhere! |
For future reference (and maybe to be added to DIPY at some point?), we've discovered this function: https://github.com/scilus/scilpy/blob/master/scilpy/reconst/sh.py#L560, which can be helpful for users of this functionality. |
@arokem once these tests pass, this is ready to review/merge. kelly has signed off too |
Add argument for sh basis types. Force legacy basis types to FALSE.
Starting edit to incorporate custom ODF files into workflow. Need to separate ODF model estimation from tracking procedure.