Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug #2513(vertexai): improve input attribute handling for prompts and conte… #2517

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kowshik24
Copy link
Contributor

Fix Bug Report: Whole message history is stringified into a single 'user prompt' #2513

  1. Bug Analysis
    Current Behavior
    Messages from chat history are combined into single string
    All roles and content merged into one user prompt
    Loses message separation and role information

  2. Root Cause
    _set_input_attributes() treating Content list as plain text
    Not properly parsing individual Content objects
    Missing logic to handle chat message format

  3. Impact
    Loss of conversation structure in telemetry
    Incorrect attribution of message roles
    Poor observability of chat interactions

  4. Fix Required
    Update _set_input_attributes() to handle Content objects
    Parse role and parts from each message
    Store each message separately with correct role
    Maintain message order with index

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 18, 2025
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


kowshik seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dosubot dosubot bot added bug Something isn't working python Pull requests that update Python code labels Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Pull requests that update Python code size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants