Reimplement macro to make writing kernels more ergonomic #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the same signature
…e variables in `Binary` and `Unary ops.
|
All tests passing including frontend tests, actually ready for merge now |
wingertge
changed the title
|
Something in burn seems to be miscompiling, going back to draft until I can figure out what's going on |
|
All burn tests are passing now. |
Comment on lines
+36
to
+39
| cubecl-core = { path = "../cubecl-core", version = "0.2", default-features = false } | ||
| cubecl-cuda = { path = "../cubecl-cuda", version = "0.2", default-features = false } | ||
| cubecl-linalg = { path = "../cubecl-linalg", version = "0.2", default-features = false } | ||
| cubecl-wgpu = { path = "../cubecl-wgpu", version = "0.2", default-features = false } |
There was a problem hiding this comment.
For the codegen comparison tests. Could move them but I put them here because they're testing the macro, not the backends in question. Or maybe just use the testgen macro thing.
…ure compiler intrinsics
nathanielsimard
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite of the frontend macro to make writing kernels more ergonomic and "rust-like".
It replaces the
Comptimestruct with a#[comptime]attribute so values can be used like any other Rust constant.Loops now use normal ranges and allow unrolling via
#[unroll]rather than a verborse comptime parameter that is often set to a literal anyways. For conditional unrolling, the attribute supports inserting an expression:#[unroll(should_unroll)].The custom vectorized types are replaced with Rust primitives since vectorization has always been stored in the IR anyways. The vectorization field on the custom types was almost entirely redundant.
Adds support for struct destructuring in locals.
Folding of comptime values into literals has also been improved.
Testing
All unit and integration tests (including frontend tests) are passing. Several backend codegen tests are also added.
All burn tests are passing.