Impl SyncStorage #72
Merged
Impl SyncStorage #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
29
to
32
| fn fmt( | ||
| &self, | ||
| f: &mut std::fmt::Formatter<'_>, | ||
| ) -> std::fmt::Result { |
There was a problem hiding this comment.
Is there a reason why the fommatting is different? What Rust version / rust-fmt are you using?
There was a problem hiding this comment.
Sorry, the number of columns in my formatting settings is relatively low. I will make the necessary changes later, but this also exposes the issue. We need an fmt file
AntiAnimeGeneral
force-pushed
the
impl-sync_storage
branch
from
54c0fb4
to
080bdaf
Compare
nathanielsimard
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storageBarrier() be used in conjunction with atomic operations to ensure visibility