Automatically enable autotune_persistent_cache only on desktop platforms #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurBrussee
changed the title
ArthurBrussee
commented
Aug 13, 2024
| @@ -80,16 +80,22 @@ impl VariableAnalyzer { | |||
| for pat in pat_tuple.elems.iter() { | |||
| let (id, is_comptime) = find_local_declaration_ident(pat); | |||
| if let Some(id) = id { | |||
| self.variable_tracker | |||
| .analyze_declare(id.to_string(), depth, is_comptime); | |||
| self.variable_tracker.analyze_declare( | |||
There was a problem hiding this comment.
This is just to keep CI happy, seems some bad formatting was comitted.
nathanielsimard
approved these changes
Aug 13, 2024
Comment on lines
+5
to
+7
| cfg_aliases! { | ||
| autotune_persistent_cache: { all(feature = "std", any(target_os = "windows", target_os = "linux", target_os = "macos")) }, | ||
| } |
There was a problem hiding this comment.
Ho I didn't know we could do that, awesome!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the persistent cache fails on platforms without easy access to a filesystem like android and the web. Configuring this as a negative feature becomes quite annoying.
Instead, as per this discord discussion, this just makes it so it's only enabled if on a desktop platform. To save some gnarly cfgs everywhere this using cfg_aliases which might be useful more generally in cube/burn, but lmk if it's preferred to not have this.
There's also a leftover flag in cubecl-cuda for autotune I think. It seems Burn actually handles all the autotune flags, cube doesn't know about them.