Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matmul cmma #6

Merged
merged 46 commits into from
Jul 18, 2024
Merged

Matmul cmma #6

merged 46 commits into from
Jul 18, 2024

Conversation

louisfd
Copy link
Member

@louisfd louisfd commented Jul 17, 2024 •
edited
Loading

Problems remaining:

  • Compute loop tests are flaky, they can fail when running in parallel.
  • There seem to be two failing tests on older tiling2d on cuda
  • We need to deactivate cmma tests on wgpu
  • We need macroscopic matmul tests that work for f16 compute, and that does not take 4k lines

louisfd and others added 30 commits July 16, 2024 11:53
@louisfd
add matmul test
0b75587
@louisfd
add use cmma const
7cd8199
@louisfd
test in shared memo
ebd0b8b
@louisfd
add depth to frag
c84d134
wip fix loop
677a2ac
compute loop with cmma works
fa24d43
@louisfd
new test
c59dfaa
bugs because load/write assume transposed
238c42a
@louisfd
transpose loading
d50effd
@louisfd
transpose write
f8cfceb
@louisfd
slice mut unsafe
00ba6eb
some notes
74eae81
:wq
a4e4a66 
wq
:wqWQMerge branch 'feat/lac' of github.com:tracel-ai/cubecl into feat/lac
@louisfd
undo
b7d83dc
@louisfd
wip outer cmma
47bb7c7
Merge branch 'feat/lac' of github.com:tracel-ai/cubecl into feat/lac
89391d1
@louisfd
write
0dea2f1
@louisfd
Merge branch 'feat/lac' of github.com:tracel-ai/cubecl into feat/lac
6bd0141
it works!
3c53da3
@louisfd
cleanup
afe67b2
@louisfd
cleanup compute
d43be27
fix two warps compute
faa03a5
cleanup compute
14e9763
fix git
dceaafe
deactivate failing test
3496276
@louisfd
deactivate cmma on wgpu
8ba8ce0
@louisfd
cpu matmul for comparison
67ead0f
matmul test
8c624ad
@louisfd
dont execute matmul cmma if cant
53818eb
@louisfd
Merge branch 'main' into feat/lac
a1923af
@nathanielsimard nathanielsimard merged commit 9ee1d45 into main Jul 18, 2024
1 of 2 checks passed
@nathanielsimard nathanielsimard deleted the feat/lac branch July 18, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louisfd @nathanielsimard