Add Support for cast instruction in hip wmma intrinsic compiler #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syl20bnr
force-pushed
the
fix/hip_wmma_intrinsic_cast_instruction
branch
from
fd9cb95
to
46daf54
Compare
|
Converting to draft, I want to fix other things that are not quite right in the intrinsic compiler. |
Comment on lines
54
to
61
| FragmentIdent::A | FragmentIdent::B => write!(f, "half16"), | ||
| FragmentIdent::Accumulator => write!(f, "float8"), | ||
| FragmentIdent::Accumulator => match fragment.elem { |
There was a problem hiding this comment.
Can we use bfloat16 in the instruction?
| @@ -139,13 +169,15 @@ for (uint i = 0; i < uint(8); ++i) {{ | |||
| } else { | |||
| panic!("{frag_a} is not a WMMA fragment!") | |||
| }; | |||
| let cd_format = if let Variable::WmmaFragment { frag: inner_c, .. } = frag_c { | |||
| if let Variable::WmmaFragment { frag: inner_d, .. } = frag_d { | |||
| let (cd_format, opsel) = if let Variable::WmmaFragment { frag: mut inner_c, .. } = frag_c { | |||
| @@ -38,6 +38,7 @@ where | |||
|
|
|||
| if A::check_availability::<R>(&client).is_err() { | |||
| // Can't execute the test. | |||
| println!("Skipped - not supported!"); | |||
syl20bnr
force-pushed
the
fix/hip_wmma_intrinsic_cast_instruction
branch
from
6a857d4
to
d3862f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.