Make spirv feature to compile on macOS #301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of tests fail though because of some device feature not present.
|
cc @wingertge |
This makes it clearer about which tests fail as the panic line is not really usable because of the macro.
syl20bnr
force-pushed
the
macos/spirv-compilation
branch
from
e1b293a
to
ffacc02
Compare
|
Does it mention the device feature somewhere? I'm enabling a bunch of features by default because as far as I can tell they should be supported on all devices, but the compatibility layer might not have them all available. The main enforced features are the Vulkan Memory model (that one seems the most likely to be missing from a compat layer but also the hardest to remove), f16/i8 support and 16 bit buffer support. CMMA is gated behind a check for device capability so it's not that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some guidance in the
build.rsfile.Lots of tests are failling though because of some device feature not present.
Also, not related to spir-v, there is one wgpu test failing
test_buffer_len_offsetwith message:The offset 5248 changes each time we execute the test.