Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chores #297

Merged
merged 4 commits into from
Nov 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/cubecl-core/src/frontend/synchronization.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use crate::ir::Synchronization;
///
/// * Then all the invocations in the cube wait for each other to arrive at the barrier, i.e. this step.
///
/// * Then all the invocations int he cube begin executing after the barrier, and any writes to cube address space that were made before the barrier are now visible to any invocation in this cube.
/// * Then all the invocations int the cube begin executing after the barrier, and all writes to cube address space made before the barrier are now visible to any invocation in this cube.
pub fn sync_units() {}

pub mod sync_units {
Expand Down
7 changes: 0 additions & 7 deletions crates/cubecl-core/src/prelude.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,6 @@ pub use crate::frontend::{
};
pub use crate::pod::CubeElement;

/// Topology
pub use crate::frontend::{
ABSOLUTE_POS, ABSOLUTE_POS_X, ABSOLUTE_POS_Y, ABSOLUTE_POS_Z, CUBE_COUNT, CUBE_COUNT_X,
CUBE_COUNT_Y, CUBE_COUNT_Z, CUBE_DIM, CUBE_DIM_X, CUBE_DIM_Y, CUBE_DIM_Z, CUBE_POS, CUBE_POS_X,
CUBE_POS_Y, CUBE_POS_Z, PLANE_DIM, UNIT_POS, UNIT_POS_X, UNIT_POS_Y, UNIT_POS_Z,
};

/// Export plane operations.
pub use crate::frontend::{plane_all, plane_max, plane_min, plane_prod, plane_sum};
pub use cubecl_runtime::client::ComputeClient;
Expand Down
4 changes: 3 additions & 1 deletion crates/cubecl-cuda/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ cubecl-core = { path = "../cubecl-core", version = "0.4.0", features = [
cubecl-linalg = { path = "../cubecl-linalg", version = "0.4.0", features = [
"export_tests",
] }
cubecl-reduce = { path = "../cubecl-reduce", version = "0.4.0" }
cubecl-reduce = { path = "../cubecl-reduce", version = "0.4.0", features = [
"export_tests",
] }
paste = { workspace = true }
pretty_assertions = { workspace = true }
4 changes: 3 additions & 1 deletion crates/cubecl-hip/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,7 @@ cubecl-core = { path = "../cubecl-core", version = "0.4.0", features = [
cubecl-linalg = { path = "../cubecl-linalg", version = "0.4.0", features = [
"export_tests",
] }
cubecl-reduce = { path = "../cubecl-reduce", version = "0.4.0" }
cubecl-reduce = { path = "../cubecl-reduce", version = "0.4.0", features = [
"export_tests",
] }
pretty_assertions = { workspace = true }
4 changes: 3 additions & 1 deletion crates/cubecl-reduce/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ authors = [
"maxtremblay <[email protected]>"
]
categories = ["science", "mathematics", "algorithms"]
description = "CubeCL Standard Library."
description = "CubeCL Reduce Algorithms."
edition.workspace = true
keywords = []
license.workspace = true
Expand All @@ -21,8 +21,10 @@ default = [
"cubecl-core/default"
]
std = ["cubecl-runtime/std", "cubecl-core/std"]
export_tests = ["pretty_assertions"]

[dependencies]
cubecl-core = { path = "../cubecl-core", version = "0.4.0", default-features = false }
cubecl-runtime = { path = "../cubecl-runtime", version = "0.4.0", default-features = false }
num-traits = "0.2.19"
pretty_assertions = { workspace = true, optional = true }
5 changes: 3 additions & 2 deletions crates/cubecl-reduce/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
pub mod test;

pub mod sum;

#[cfg(feature = "export_tests")]
pub mod test;
4 changes: 3 additions & 1 deletion crates/cubecl-wgpu/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@ cubecl-core = { path = "../cubecl-core", version = "0.4.0", features = [
cubecl-linalg = { path = "../cubecl-linalg", version = "0.4.0", features = [
"export_tests",
] }
cubecl-reduce = { path = "../cubecl-reduce", version = "0.4.0" }
cubecl-reduce = { path = "../cubecl-reduce", version = "0.4.0", features = [
"export_tests",
] }
half = { workspace = true }
paste = { workspace = true }
pretty_assertions = { workspace = true }
Expand Down
Loading