Add for in syntax for immutable arrays, tensors and slices
#119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _context: &mut CubeContext, | ||
| _body: impl FnMut(&mut CubeContext, <T::Item as CubeType>::ExpandType), | ||
| ) { | ||
| unimplemented!("Can't unroll array iterator") |
There was a problem hiding this comment.
it would be cool to support unroll. I guess we would need a way to know if the len is comptime as well.
There was a problem hiding this comment.
Unfortunately there currently isn't infrastructure for that. Could make it work for shared memory and local arrays in theory, but we'd need to add the comptime size to the ExpandElement or something like that to read it in the iterator.
nathanielsimard
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
for item in arraysyntax for&Array,&TensorandSlice. This currently only implements immutable iterators until we can figure out a way to implement mutable references into arrays.Testing
Adds a frontend and a runtime test to ensure it works properly.