Cmma major refactor #101
Merged
Cmma major refactor #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l into refactor/cmma_generalize
…l into refactor/cmma_generalize
…l into refactor/cmma_generalize
Closed
…o feat/reuse_out_smem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cmma matmul is now much more flexible, and seemingly faster with some newly available configurations.
It seems there is still a bug if b_k > 32, but will work well at b_k = 16 [EDIT: solved. Bugs only at very large values, like 128x32, in f32, or 128x64 in f16, which is normal]
Fix #12
Fix #15 (after some research it seems like shared memory is the way to go. But at least now it's not of size B_M*B_N but rather of size
size of tile * number of coops)