Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs:API周りのドキュメントを作成 #72

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

mathsuky
Copy link
Collaborator

@mathsuky mathsuky commented Dec 2, 2024

非常に簡単なものですが,API周りのセットアップに必要なことを簡単に記入しました。

Copy link
Collaborator

@YuHima03 YuHima03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!
1点だけ気になる部分があったのでご確認お願いします 🙇‍♂️

README.md Outdated

## mockサーバーの立ち上げ方

開発環境においては,モックサーバーを利用します。モックサーバーの立ち上げには`./run-mock-api.sh`を実行してください。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

パスの部分、 scripts が抜けている気がします.

@mathsuky
Copy link
Collaborator Author

mathsuky commented Dec 2, 2024

ありがとうございます,再レビューお願いします:pray:

@mathsuky mathsuky requested a review from YuHima03 December 2, 2024 13:55
Copy link
Collaborator

@YuHima03 YuHima03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ありがとうございます!

@mathsuky mathsuky merged commit 41d9507 into main Dec 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants