Skip to content

Commit

Permalink
OvmfPkg: Disable PcdFirstTimeWakeUpAPsBySipi.
Browse files Browse the repository at this point in the history
Disable PcdFirstTimeWakeUpAPsBySipi for OVMF to let BSP wake up APs by
INIT-SIPI-SIPI.

Cc: Eric Dong <[email protected]>
Cc: Ray Ni <[email protected]>
Cc: Rahul Kumar <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Jordan Justen <[email protected]>
Signed-off-by: Yuanhao Xie <[email protected]>
Reviewed-by: Ray Ni <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]>
  • Loading branch information
xieyuanh authored and mergify[bot] committed Aug 14, 2023
1 parent 98e9d29 commit 1d76560
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 1 deletion.
9 changes: 8 additions & 1 deletion OvmfPkg/OvmfPkgIa32.dsc
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
## @file
# EFI/Framework Open Virtual Machine Firmware (OVMF) platform
#
# Copyright (c) 2006 - 2022, Intel Corporation. All rights reserved.<BR>
# Copyright (c) 2006 - 2023, Intel Corporation. All rights reserved.<BR>
# (C) Copyright 2016 Hewlett Packard Enterprise Development LP<BR>
# Copyright (c) Microsoft Corporation.
#
Expand Down Expand Up @@ -585,6 +585,13 @@

# Point to the MdeModulePkg/Application/UiApp/UiApp.inf
gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
#
# INIT is now triggered before BIOS by ucode/hardware. In the OVMF
# environment, QEMU lacks a simulation for the INIT process.
# To address this, PcdFirstTimeWakeUpAPsBySipi set to FALSE to
# broadcast INIT-SIPI-SIPI for the first time.
#
gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi|FALSE

################################################################################
#
Expand Down
7 changes: 7 additions & 0 deletions OvmfPkg/OvmfPkgIa32X64.dsc
Original file line number Diff line number Diff line change
Expand Up @@ -566,6 +566,13 @@
!if $(SOURCE_DEBUG_ENABLE) == TRUE
gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdDebugLoadImageMethod|0x2
!endif
#
# INIT is now triggered before BIOS by ucode/hardware. In the OVMF
# environment, QEMU lacks a simulation for the INIT process.
# To address this, PcdFirstTimeWakeUpAPsBySipi set to FALSE to
# broadcast INIT-SIPI-SIPI for the first time.
#
gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi|FALSE

[PcdsFixedAtBuild.IA32]
#
Expand Down
7 changes: 7 additions & 0 deletions OvmfPkg/OvmfPkgX64.dsc
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,13 @@

# Point to the MdeModulePkg/Application/UiApp/UiApp.inf
gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
#
# INIT is now triggered before BIOS by ucode/hardware. In the OVMF
# environment, QEMU lacks a simulation for the INIT process.
# To address this, PcdFirstTimeWakeUpAPsBySipi set to FALSE to
# broadcast INIT-SIPI-SIPI for the first time.
#
gUefiCpuPkgTokenSpaceGuid.PcdFirstTimeWakeUpAPsBySipi|FALSE

################################################################################
#
Expand Down

0 comments on commit 1d76560

Please sign in to comment.