Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pyzet query for easier searching of knowledge inside ZK #59

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

tpwo
Copy link
Owner

@tpwo tpwo commented Oct 19, 2024

Implementation of idea suggested in #58.

TODO:

  • merge the newest main to the branch and fix merge conflicts
  • fix any failing tests and make sure new code is covered
  • fix linting errors (namely ruff errors)
  • handle open TODOs (either create issues or address them)
  • think about nice to have features which make it easier to use pyzet query

pyzet starts to be more stateful, and it asks what to do next, after
previous action (like adding, opening, printing) was finished.

This is a huge change in the philosophy how to use the tool, but I
really like the new flow.

This is still big WIP, there are issues with a lot of tests, and very
likely a lot of hidden bugs which I will be gradually fixing with time.

I still believe that this is worth the effort, as working with the new
flow is very convenient in my ZK repo with 500+ notes.
It seems that `side_effect` has to be used over `return_value`.
`KeyboardInterrupt` seems to work pretty well as the 2nd side effect.

I'm not sure if this is the best appraoch, but these tests were broken
last time I modified the code which was 9 months ago, so for now I just
want to fix them.

Note that 3 tests still fail at this point.
TODO errors are skipped for now, as they can be closed before merging to
main.
For now this is a single person project.
I observed it, but I'm not sure if this is really bad. I guess it's fine
for now.
For now we can just merge it without bumping the version.

This reverts commit 6d251fc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant